[Infra] Cleaned Up Includes in Draw Dir #3071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up the includes in the draw files. These ones were much messier than I originally thought. Many of the header files in the draw directory included way more than they needed which was causing false dependencies anywhere in VPR which included any draw files.
AlexandreSinger
force-pushed
the
feature-include-cleanup
branch
from
6db2e53 to
f742d10
Compare
github-actions
bot
added
VPR
soheilshahrouz
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the includes in the draw files. These ones were much messier than I originally thought. Many of the header files in the draw directory included way more than they needed which was causing false dependencies anywhere in VPR which included any draw files.