Skip to content

[Infra] Cleaned Up Header Files in Route Folder #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexandreSinger
Copy link
Contributor

Continued the header file cleanup effort in the route folder.

Some of these files may need to be revisited in more detail, but got some of the major header include issues.

Found that some definitions were in the wrong place, so moved them to the correct implementation file.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels May 20, 2025
Continued the header file cleanup effort in the route folder.

Some of these files may need to be revisited in more detail, but got
some of the major header include issues.

Found that some definitions were in the wrong place, so moved them to
the correct implementation file.
@AlexandreSinger AlexandreSinger force-pushed the feature-include-cleanup branch from f07b15d to 93aba7c Compare May 20, 2025 16:28
Copy link
Contributor

@soheilshahrouz soheilshahrouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up header file includes!

I left a few comments to gradually move the code base towards a more uniform style. These comments are not related to the code you wrote, but I though it would be a good opportunity to make these changes.

Moved to pragma once symantics and cleaned up some less than ideal
code.
@soheilshahrouz
Copy link
Contributor

Thanks @AlexandreSinger

@AlexandreSinger AlexandreSinger merged commit debf7c1 into verilog-to-routing:master May 20, 2025
36 checks passed
@AlexandreSinger AlexandreSinger deleted the feature-include-cleanup branch May 20, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants