-
Notifications
You must be signed in to change notification settings - Fork 414
Remove PlacerMoveContext #2989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PlacerMoveContext #2989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Soheil! Overall, the PR looks good. I just left a few minor comments. Also, since you're modifying some performance-critical parts of the code, I'd suggest running the Titan benchmark on the SAVI machine and comparing its runtime against the master branch to ensure there are no significant regressions.
Results for VTR benchmarks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
PlacerMoveContext
class contained bounding-box information for clustered nets, some scratchpad vectors, andfirst_rlim
. This PR moves all bounding-box related info toNetCostHandler
. Scratchpad vectors are moved to classes that use them, andfirst_rlim
is now a static data member ofMoveGenerator
.