Skip to content

Remove PlacerMoveContext #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 21, 2025
Merged

Remove PlacerMoveContext #2989

merged 14 commits into from
Apr 21, 2025

Conversation

soheilshahrouz
Copy link
Contributor

PlacerMoveContext class contained bounding-box information for clustered nets, some scratchpad vectors, and first_rlim. This PR moves all bounding-box related info to NetCostHandler. Scratchpad vectors are moved to classes that use them, and first_rlim is now a static data member of MoveGenerator.

@soheilshahrouz soheilshahrouz requested a review from amin1377 April 19, 2025 16:25
@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Apr 19, 2025
Copy link
Contributor

@amin1377 amin1377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Soheil! Overall, the PR looks good. I just left a few minor comments. Also, since you're modifying some performance-critical parts of the code, I'd suggest running the Titan benchmark on the SAVI machine and comparing its runtime against the master branch to ensure there are no significant regressions.

@soheilshahrouz
Copy link
Contributor Author

Results for VTR benchmarks

Metric master feature
vtr_flow_elapsed_time 1 0.9956233242
parmys_synth_time 1 0.9984187005
abc_depth 1 1
abc_synth_time 1 0.9992354382
num_clb 1 1
num_memories 1 1
num_mult 1 1
max_vpr_mem 1 1.001330976
num_pre_packed_blocks 1 1
num_post_packed_blocks 1 1
device_grid_tiles 1 1
pack_time 1 0.9930076
placed_wirelength_est 1 1
place_time 1 1.010553331
placed_CPD_est 1 1
min_chan_width 1 1
routed_wirelength 1 1
min_chan_width_route_time 1 0.9870603223
crit_path_routed_wirelength 1 1
critical_path_delay 1 1
geomean_nonvirtual_intradomain_critical_path_delay 1 1
crit_path_route_time 1 1.008222132

Copy link
Contributor

@amin1377 amin1377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amin1377 amin1377 merged commit f71176c into master Apr 21, 2025
36 checks passed
@amin1377 amin1377 deleted the temp_remove_place_move_ctx branch April 21, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants