Skip to content

Clean RR graph generation code #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 16, 2025
Merged

Clean RR graph generation code #2977

merged 18 commits into from
Apr 16, 2025

Conversation

soheilshahrouz
Copy link
Contributor

@soheilshahrouz soheilshahrouz commented Apr 14, 2025 •
edited
Loading

Cleans up the the RR graph generate code a bit.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool libarchfpga Library for handling FPGA Architecture descriptions lang-cpp C/C++ code labels Apr 14, 2025
vaughnbetz
vaughnbetz approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup, thanks!
It's a lot of code, so it would be best to run the nightly tests too.

@soheilshahrouz soheilshahrouz changed the title [WIP] Clean RR graph generation code Clean RR graph generation code Apr 15, 2025
@soheilshahrouz
Copy link
Contributor Author

Fixed the strong test failure for S10.

@soheilshahrouz
Copy link
Contributor Author

@vaughnbetz
I ran the nightly tests. Some 3D tests are currently failing on master, and the same ones fail on this branch. No other tests are failing.

@vaughnbetz
Copy link
Contributor

Thanks!

@vaughnbetz vaughnbetz merged commit 1dff246 into master Apr 16, 2025
36 checks passed
@vaughnbetz vaughnbetz deleted the temp_clean_rrgraph_gen branch April 16, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz vaughnbetz approved these changes

Assignees
No one assigned
Labels
lang-cpp C/C++ code libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soheilshahrouz @vaughnbetz