Skip to content

[Place] Fix regex pattern note in constraints doc #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Conversation

amin1377
Copy link
Contributor

Updated the placement constraint documentation to clarify that the name_pattern specified in the <add_atom> tag is interpreted as a regular expression. Also fixed a minor issue in the examples: the documentation previously suggested using * after a name to match any suffix (e.g., "alu*"), but in regex, * applies only to the preceding character. To correctly match any suffix, the pattern should use .* (e.g., "alu.*").

@amin1377 amin1377 requested a review from vaughnbetz March 26, 2025 21:43
@github-actions github-actions bot added the docs Documentation label Mar 26, 2025
@vaughnb-cerebras
Copy link

LGTM!

@vaughnbetz vaughnbetz merged commit 16b900f into master Mar 26, 2025
4 checks passed
@vaughnbetz vaughnbetz deleted the floorplan_doc branch March 26, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants