[AP][Solver] Supporting Unfixed Blocks #2944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
amin1377
requested changes
Mar 20, 2025
|
|
||
| // Update the guess. The guess for the next iteration is the solution in | ||
| // this iteration. | ||
| guess_x = x; |
There was a problem hiding this comment.
By the way, did this update affect the results? Given how fast the solver already is, I wouldn’t expect to see any significant improvement in runtime, though.
There was a problem hiding this comment.
It improved the runtime. The QoR does change, but I would not expect it to change by much. I will run Titan to see!
When no fixed blocks are provided by the user, the AP flow can still work. Currently, in the first iteration, the solver will put all blocks at 0,0 and use the legalized solution in the next iteration as fixed points. Instead of (0,0), it makes more sense to put the blocks in the center of the device. Also added a guess to the solver to help CG converge faster each iteration. Added a regression test to ensure that not describing the fixed blocks is supported.
AlexandreSinger
force-pushed
the
feature-ap-solver
branch
from
b1b766d to
b26c2d2
Compare
|
Titan result:
The runtime seems to be the same; but on the largest circuits, the runtime improved. One thing I noticed is that some of the larger circuits are getting better results now. My guess is that some of the larger circuits are hitting the iteration limits of the CG solver which may be causing them to converge on slightly different answers. It seems to have made some better and some worst, but overall the WL remained the same relative to baseline. I think this is good to merge. |
amin1377
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no fixed blocks are provided by the user, the AP flow can still work. Currently, in the first iteration, the solver will put all blocks at 0,0 and use the legalized solution in the next iteration as fixed points. Instead of (0,0), it makes more sense to put the blocks in the center of the device.
Also added a guess to the solver to help CG converge faster each iteration.
Added a regression test to ensure that not describing the fixed blocks is supported.