Fix clang format version #2943
Closed
Fix clang format version #2943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running 'make format' when clang-format version is not 14 resulted in a crash since the build scripts specifically asks for clang-format version 14. This commit fixes that and makes it possible to use the default clang-format installed on the user's system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running 'make format' when clang-format version is not 14 resulted in a crash since the build scripts specifically asks for clang-format version 14. This commit fixes that and makes it possible to use the default clang-format installed on the user's system.
Fixes #2940
This should not affect CI in any way since the dependency install scripts install clang-format version 14.