Skip to content

Remove Redundant print_pb #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Remove Redundant print_pb #2939

merged 2 commits into from
Mar 19, 2025

Conversation

amin1377
Copy link
Contributor

The print_pb_type_count function is currently called twice: once in vpr_oad_packing and again in AAPack::legalize after loading the packing from a file. In this PR, the redundant second call is removed.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Mar 18, 2025
Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for fixing this! It was a leftover from an older version of the Full Legalizer. I just had one minor comment.

Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandreSinger AlexandreSinger merged commit 3a19e8d into master Mar 19, 2025
36 checks passed
@AlexandreSinger AlexandreSinger deleted the redundant_print_pb branch March 19, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants