[AP][FullLegalizer] Basic Min. Disturbance Full Legalizer #2921
Conversation
Added read flat placement to AP flow and and command line option for Basic Min. Disturbance FL.
github-actions
bot
added
VPR
There was a problem hiding this comment.
Hi @haydar-c , this PR is looking good. Just some comments.
| @@ -15,6 +15,7 @@ | |||
| */ | |||
| enum class e_ap_full_legalizer { | |||
| Naive, ///< The Naive Full Legalizer, which clusters atoms placed in the same tile and tries to place them in that tile according to the flat placement. | |||
| APPack ///< The APPack Full Legalizer, which uses the flat placement to improve the Packer and Placer. | |||
| APPack, ///< The APPack Full Legalizer, which uses the flat placement to improve the Packer and Placer. | |||
| Basic_Min_Disturbance ///< The Basic Min. Disturbance Full Legalizer, which uses flat placement and tries to reconstruct clusters identically. The method for handling orphan clusters has not yet been determined. | |||
There was a problem hiding this comment.
I would say something like "which tries to reconstruct a clustered placement as close to the incoming flat placement as it can". I would leave off the orphan cluster sentence for now. It is very easy to forget to remove that sentence. I recommend writing this sentence as if you finished the min disturbance full legalizer.
Changes based on review.
Style change.
Changes based on review (VtrError and commenting)
There was a problem hiding this comment.
Hi @haydar-c , last few comments.
The most major one is the use of t_pl_loc in the AP context. We have to be careful when using structs designed for clustered placement. This struct, for example, stores position as integers; however, in AP we store positions as floats.
Using floats for location in flat and partial palcement. Also error handling.
Using floats for location in flat and partial placement. Changed error handling.
Added the "basic_min_disturbance" command line options into the AP Flow. Ideally, this will be another Full Legalizer method when implemented on top of the ones here (https://docs.verilogtorouting.org/en/latest/vpr/command_line_usage/#cmdoption-vpr-ap_full_legalizer).
I also added the reading from flat placement and writing to flat placement into AP Flow. If the read option is provided, Global Placement is skipped and Partial Placement is constructed with provided flat placement information. If the write option is provided, flat placement is written at the end of AP Flow.