Skip to content

[Place] Grid Location to Compressed Location #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 7, 2025
Merged

[Place] Grid Location to Compressed Location #2919

merged 9 commits into from
Mar 7, 2025

Conversation

amin1377
Copy link
Contributor

@amin1377 amin1377 commented Mar 3, 2025

Description

Fix the bug with getting compressed location from grid location.

@amin1377 amin1377 requested a review from soheilshahrouz March 3, 2025 14:03
@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Mar 3, 2025
soheilshahrouz
soheilshahrouz reviewed Mar 3, 2025
View reviewed changes
vaughnbetz
vaughnbetz requested changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One bug soheil found, plus a few comments

@vaughnbetz
Copy link
Contributor

vaughnbetz commented Mar 5, 2025 •
edited
Loading

Looks like there is a bug; I assume a debug assert is firing, as many circuits failed in the highest assertion level test. I don't see the assert failure in the output though; here are the last lines (which imply we vpr crashes right at the start of placement):

### Computing src/opin lookahead took 0.01 seconds (max_rss 74.8 MiB, delta_rss +0.0 MiB)
## Computing router lookahead map took 0.21 seconds (max_rss 74.8 MiB, delta_rss +0.0 MiB)
Serial Connection Router is being destroyed. Time spent on path search: 0.000 seconds.
# Computing placement delta delay look-up took 1.63 seconds (max_rss 74.8 MiB, delta_rss +0.0 MiB)
# Placement
## Initial Placement

@amin1377 amin1377 mentioned this pull request Mar 6, 2025
Closed
vaughnbetz
vaughnbetz approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaughnbetz
Copy link
Contributor

Ready to merge?
Also is #2925 meant to be permanently closed without merging?

@amin1377
Copy link
Contributor Author

amin1377 commented Mar 7, 2025

Ready to merge? Also is #2925 meant to be permanently closed without merging?

Yes, it is ready to merge. Regarding #2925, please merge #2926 instead. Thanks!

@vaughnbetz vaughnbetz merged commit b89f681 into master Mar 7, 2025
36 checks passed
@vaughnbetz vaughnbetz deleted the loc_to_compressed_debug branch March 7, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soheilshahrouz soheilshahrouz soheilshahrouz left review comments

@vaughnbetz vaughnbetz vaughnbetz approved these changes

Assignees
No one assigned
Labels
lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amin1377 @vaughnbetz @soheilshahrouz