Make Nightly Tests Continue on Error #2910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the Nightly Tests will stop whenever any of the Nightly Tests fail (and will not run the following tests). So for example, if Nightly Test 1 has a QoR failure, all other Nightly tests will not be run. Made each step in the Nightly Test manual job continue on error. This will run the following steps even if one of them fail. Suggested-by: Alex Singer
|
@AlexandreSinger Do you mind checking to see if this fixes the problem? |
AlexandreSinger
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the same thing as #2905 but uses a different way to do it that hopefully avoids the issue of the run being considered successful even if some tests have failed. Did it in a different PR and branch because I didn't want to mess with the origin too much.