Skip to content

remove : capacity attribute in tile #2904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

markram1729
Copy link
Contributor

Description

Related Issue

#2903

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the docs Documentation label Feb 21, 2025
Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for noticing this! I just had one minor comment.

@vaughnbetz I have checked the code and ensured that this property is not being parsed within VTR:

static void ProcessTileProps(pugi::xml_node Node,
t_physical_tile_type* PhysicalTileType,
const pugiutil::loc_data& loc_data) {
expect_only_attributes(Node, {"name", "width", "height", "area"}, loc_data);
/* Load type name */
auto Prop = get_attribute(Node, "name", loc_data).value();
PhysicalTileType->name = Prop;
/* Load properties */
PhysicalTileType->width = get_attribute(Node, "width", loc_data, ReqOpt::OPTIONAL).as_uint(1);
PhysicalTileType->height = get_attribute(Node, "height", loc_data, ReqOpt::OPTIONAL).as_uint(1);
PhysicalTileType->area = get_attribute(Node, "area", loc_data, ReqOpt::OPTIONAL).as_float(UNDEFINED);
if (atof(Prop) < 0) {
archfpga_throw(loc_data.filename_c_str(), loc_data.line(Node),
"Area for type %s must be non-negative\n", PhysicalTileType->name.c_str());
}
}

The t_physical_tile_type struct does have a member called "capacity"; however, according to the parser this is defined as the sum of the capacities of all sub-tiles in this physical tile type. So I think the change in this PR is correct.

Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@AlexandreSinger AlexandreSinger merged commit a33fa95 into verilog-to-routing:master Feb 24, 2025
4 checks passed
@vaughnbetz
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants