[Place] Moved PlaceMacros Out of BlkLocRegistry #2896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
vaughnbetz
reviewed
Feb 14, 2025
|
I'm OK with passing around place_macros more if you want, but not sure why this would be a member of the clustering context. That seems like a step backward. |
|
Sounds good, thanks. |
The PlaceMacros only require the Clustering and atom/arch info to be constructed; after which they are never modified. Since they are unchanged by the placement, they were out of place in the BlkLocRegistry. Moved them to the clustering context since they only make sense once the clusters are loaded. This will make it easier to separate out the initial placement from the SA placer.
Vaughn thought that the place macros made more sense in the placement context instead of the clustering context.
AlexandreSinger
force-pushed
the
feature-ap-detailed-placer
branch
from
b53162c to
38b09e2
Compare
|
I have updated the location of the PlaceMacros to the placement context. @soheilshahrouz do you have any comments? |
|
Thanks for the review @soheilshahrouz ! @vaughnbetz Do you have any further comments? |
|
LGTM, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PlaceMacros only require the Clustering and atom/arch info to be constructed; after which they are never modified. Since they are unchanged by the placement, they were out of place in the BlkLocRegistry.
Moved them to the placement context.
This will make it easier to separate out the initial placement from the SA placer.