[Prepack] Improved Documentation on Molecule Chains #2891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
vaughnbetz
reviewed
Feb 10, 2025
Improved the documentation on how chains are handled in the prepacker. The prepacker segments chains into multiple molecules (where each molecule can fit into a single cluster). The prepacker maintains MoleculeChainIds to the chain these molecules are a part of. This allows the cluster legalizer to easily put the molecules into clusters and understand when a molecule is part of a special chain (for gain calculation).
AlexandreSinger
force-pushed
the
feature-prepacker-cleanup
branch
from
f215dbf to
035ae0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the documentation on how chains are handled in the prepacker. The prepacker segments chains into multiple molecules (where each molecule can fit into a single cluster). The prepacker maintains MoleculeChainIds to the chain these molecules are a part of. This allows the cluster legalizer to easily put the molecules into clusters and understand when a molecule is part of a special chain (for gain calculation).