Skip to content

[CI] Added GCC-13 on Ubuntu Noble as a Compatibility Test #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexandreSinger
Copy link
Contributor

Now that the GCC-13 build on Ubuntu Noble is warning clean, adding it to the CI to maintain it. This is a stepping stone to moving the entire CI to Ubuntu Noble.

@github-actions github-actions bot added the infra Project Infrastructure label Dec 3, 2024
@vaughnbetz
Copy link
Contributor

@w0lek : It looks like this warning needs to be fixed so we can move to Ubuntu 24.04 and be warning clean.

[ 71%] Building CXX object libs/EXTERNAL/sockpp/src/CMakeFiles/sockpp-objs.dir/unix/unix_address.cpp.o
/home/runner/work/vtr-verilog-to-routing/vtr-verilog-to-routing/libs/EXTERNAL/sockpp/src/unix/unix_address.cpp: In constructor ‘sockpp::unix_address::unix_address(const std::string&)’:
/home/runner/work/vtr-verilog-to-routing/vtr-verilog-to-routing/libs/EXTERNAL/sockpp/src/unix/unix_address.cpp:55:18: error: ‘char* _builtin_strncpy(char*, const char*, long unsigned int)’ specified bound 108 equals destination size [-Werror=stringop-truncation]
55 | ::strncpy(addr
.sun_path, path.c_str(), MAX_PATH_NAME);
| ^
cc1plus: all warnings being treated as errors

@w0lek
Copy link
Contributor

w0lek commented Dec 17, 2024

@w0lek : It looks like this warning needs to be fixed so we can move to Ubuntu 24.04 and be warning clean.

[ 71%] Building CXX object libs/EXTERNAL/sockpp/src/CMakeFiles/sockpp-objs.dir/unix/unix_address.cpp.o /home/runner/work/vtr-verilog-to-routing/vtr-verilog-to-routing/libs/EXTERNAL/sockpp/src/unix/unix_address.cpp: In constructor ‘sockpp::unix_address::unix_address(const std::string&)’: /home/runner/work/vtr-verilog-to-routing/vtr-verilog-to-routing/libs/EXTERNAL/sockpp/src/unix/unix_address.cpp:55:18: error: ‘char* _builtin_strncpy(char*, const char*, long unsigned int)’ specified bound 108 equals destination size [-Werror=stringop-truncation] 55 | ::strncpy(addr.sun_path, path.c_str(), MAX_PATH_NAME); | ^ cc1plus: all warnings being treated as errors

Thank you. I created PR #2845
with a fix. I don't have ubuntu 24.04 locally to check, so i am going to wait CI result in #2845

@AlexandreSinger
Copy link
Contributor Author

@w0lek That fixed the warning! Thank you! The GCC13 test is only on this PR, so I pulled your changes into this PR. They passed the test. The test is still failing due to another (unrelated) warning.

@github-actions github-actions bot added the lang-cpp C/C++ code label Dec 21, 2024
Now that the GCC-13 build on Ubuntu Noble is warning clean, adding it to
the CI to maintain it. This is a stepping stone to moving the entire CI
to Ubuntu Noble.
The G_APPLICATION_FLAGS_NONE enum was deprecated in recent versions of
GLib and was replaced by G_APPLICATION_DEFAULT_FLAGS; however, the
replacement enum was not introduced until GLib 2.74. Added code that
will select which enum to use depending on the GLib version to keep EZGL
backwards compatible.
@AlexandreSinger AlexandreSinger force-pushed the feature-ci-noble-upgrade branch from 359b3a8 to 365f7da Compare December 21, 2024 19:28
@AlexandreSinger
Copy link
Contributor Author

@vaughnbetz With this minor change to libezgl, the Ubuntu 24.04 build of VTR now appears to be warning clean. Please review when you have a moment. After this PR is merged, I will begin the process of migrating the entire CI to 24.04 (instead of just this one test). I will keep a test to ensure that Ubuntu 22.04 is also warning clean.

Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Feel free to merge if CI passes.

@AlexandreSinger AlexandreSinger merged commit 0b20db9 into verilog-to-routing:master Dec 21, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external_libs infra Project Infrastructure lang-cpp C/C++ code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants