-
Notifications
You must be signed in to change notification settings - Fork 415
[CI] Added GCC-13 on Ubuntu Noble as a Compatibility Test #2834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Added GCC-13 on Ubuntu Noble as a Compatibility Test #2834
Conversation
@w0lek : It looks like this warning needs to be fixed so we can move to Ubuntu 24.04 and be warning clean. [ 71%] Building CXX object libs/EXTERNAL/sockpp/src/CMakeFiles/sockpp-objs.dir/unix/unix_address.cpp.o |
Thank you. I created PR #2845 |
@w0lek That fixed the warning! Thank you! The GCC13 test is only on this PR, so I pulled your changes into this PR. They passed the test. The test is still failing due to another (unrelated) warning. |
Now that the GCC-13 build on Ubuntu Noble is warning clean, adding it to the CI to maintain it. This is a stepping stone to moving the entire CI to Ubuntu Noble.
The G_APPLICATION_FLAGS_NONE enum was deprecated in recent versions of GLib and was replaced by G_APPLICATION_DEFAULT_FLAGS; however, the replacement enum was not introduced until GLib 2.74. Added code that will select which enum to use depending on the GLib version to keep EZGL backwards compatible.
359b3a8
to
365f7da
Compare
@vaughnbetz With this minor change to libezgl, the Ubuntu 24.04 build of VTR now appears to be warning clean. Please review when you have a moment. After this PR is merged, I will begin the process of migrating the entire CI to 24.04 (instead of just this one test). I will keep a test to ensure that Ubuntu 22.04 is also warning clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Feel free to merge if CI passes.
Now that the GCC-13 build on Ubuntu Noble is warning clean, adding it to the CI to maintain it. This is a stepping stone to moving the entire CI to Ubuntu Noble.