Skip to content

[Warnings] Fixed Minor Warnings #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AlexandreSinger
Copy link
Contributor

Fixed a warning with a loop induction variable not being initialized.

Fixed a warning where a method overrides the base class, but was not explicitly declared as override.

Resolves #2831

Fixed a warning with a loop induction variable not being initialized.

Fixed a warning where a method overrides the base class, but was not
explicitly declared as override.
@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code libvtrutil labels Nov 30, 2024
@vaughnbetz vaughnbetz merged commit ce706d5 into verilog-to-routing:master Nov 30, 2024
37 checks passed
@vaughnbetz
Copy link
Contributor

@heshpdx @amin1377 : worth checking if this uninitialized variable also exists in the spec version of the code.

for (size_t kk; kk < N - 1; kk++) {

@heshpdx
Copy link
Contributor

heshpdx commented Dec 20, 2024

Yup, got it, thank you!

@AlexandreSinger AlexandreSinger deleted the feature-spec-warnings branch December 20, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code libvtrutil VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPECRand] Uninitialized Induction Variable in spec_rand.cpp
3 participants