Skip to content

[Warnings] Resolved Basic Warnings for GCC13 #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2024
Merged

[Warnings] Resolved Basic Warnings for GCC13 #2830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/librrgraph/src/io/gen/rr_graph_uxsdcxx.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4360,7 +4360,7 @@ inline void attr_error(std::bitset<N> astate, const char * const *lookup, const
}

inline void get_line_number(const char *filename, std::ptrdiff_t target_offset, int * line, int * col) {
std::unique_ptr<FILE,decltype(&fclose)> f(fopen(filename, "rb"), fclose);
std::unique_ptr<FILE,int(*)(FILE*)> f(fopen(filename, "rb"), fclose);

if (!f) {
throw std::runtime_error(std::string("Failed to open file") + filename);
Expand Down
2 changes: 1 addition & 1 deletion vpr/src/base/gen/vpr_constraints_uxsdcxx.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1207,7 +1207,7 @@ inline void attr_error(std::bitset<N> astate, const char* const* lookup, const s
}

inline void get_line_number(const char* filename, std::ptrdiff_t target_offset, int* line, int* col) {
std::unique_ptr<FILE, decltype(&fclose)> f(fopen(filename, "rb"), fclose);
std::unique_ptr<FILE,int(*)(FILE*)> f(fopen(filename, "rb"), fclose);

if (!f) {
throw std::runtime_error(std::string("Failed to open file") + filename);
Expand Down
3 changes: 1 addition & 2 deletions vpr/src/draw/draw_rr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,8 +902,7 @@ void draw_get_rr_pin_coords(const t_rr_node& node, float* xcen, float* ycen, con

default:
vpr_throw(VPR_ERROR_OTHER, __FILE__, __LINE__,
"in draw_get_rr_pin_coords: Unexpected side %s.\n",
TOTAL_2D_SIDE_STRINGS[pin_side]);
"in draw_get_rr_pin_coords: Unexpected side.\n");
break;
}

Expand Down
6 changes: 4 additions & 2 deletions vpr/src/draw/search_bar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ void search_and_highlight(GtkWidget* /*widget*/, ezgl::application* app) {
warning_dialog_box("Invalid Net Name");
return; //name not exist
}
for(auto clb_net_id: atom_ctx.lookup.clb_nets(atom_net_id).value()){

const auto clb_nets = atom_ctx.lookup.clb_nets(atom_net_id);
for(auto clb_net_id: clb_nets.value()){
highlight_nets(clb_net_id);
}
}
Expand Down Expand Up @@ -541,4 +543,4 @@ std::string get_search_type(ezgl::application* app) {
return searchType;
}

#endif /* NO_GRAPHICS */
#endif /* NO_GRAPHICS */