[Packer] Clean Up Clustering Algorithm #2823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
AlexandreSinger
force-pushed
the
feature-packer-clusterer-cleanup
branch
from
1c882a1 to
102ef79
Compare
|
I think you mean no functionality is changed :). |
Cleaned up the overall clustering algorithm in the greedy clusterer class. This change is non-functional, the control flow was rearanged and inlined / outlined to make the overall clustering algorithm more clear. More needs to be done to abstract timing and the gain calculation.
Changed when the clustering progress stats are updated and printed to make them more accurate. Changed how the LE block counts are stored to make the code easier to read. Fixed some comments.
AlexandreSinger
force-pushed
the
feature-packer-clusterer-cleanup
branch
from
102ef79 to
0f4842d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the overall clustering algorithm in the greedy clusterer class. This change is non-functional, the control flow was rearanged and inlined / outlined to make the overall clustering algorithm more clear.
More needs to be done to abstract timing and the gain calculation which is coming soon.