[CMake] Upgrade Minimum Version to 3.10 #2812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI currently always runs on the latest version of CMake. I am not sure why this is, its not the best practice, but CMake is a fairly stable application so it should be fine. CMake is deprecating version 3.9, and a few CMake files require the minimum version to be 3.9 or larger. Changed these files to be 3.10 or later.
|
@vaughnbetz The CI is currently failing for all tests due to it tracking the most recent version of CMake and CMake deprecating version 3.9. I have raised our requirements to version 3.10 of CMake (this only affected 3 files, 2 of which were EZGL). This fixed the issues. Please review and merge when you get a moment. |
|
Thanks @AlexandreSinger ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI currently always runs on the latest version of CMake. I am not sure why this is, its not the best practice, but CMake is a fairly stable application so it should be fine.
CMake is deprecating version 3.9, and a few CMake files require the minimum version to be 3.9 or larger. Changed these files to be 3.10 or later.
This is currently causing the CI to fail for basically all of the tests with the following errors:
