[CI] Fixed Bad Golden Results #2734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The golden results for one of the tests in vtr_reg_nightly_test3 was probably generated when the machine was more loaded than normal and was significantly slower than the CI. This caused a testcase to fail sometimes. This fixes the golden result to prevent the test from failing.
AlexandreSinger
force-pushed
the
feature-ci-fix-golden
branch
from
6580b06 to
f6f284b
Compare
|
@vaughnbetz I took the liberty of merging this in myself. Looks like a couple of testcases were close to the edge and were failing intermittently. I updated the golden solutions to prevent them from failing. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golden results for one of the tests in vtr_reg_nightly_test3 was probably generated when the machine was more loaded than normal and was significantly slower than the CI. This caused a testcase to fail sometimes. This fixes the golden result to prevent the test from failing.