[AP] Created The APNetlist Class #2733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
|
@vaughnbetz This PR is the first of many. It brings in the APNetlist into VPR. It also begins the new |
The APNetlist class holds the blocks and nets used during the AP flow. In the AP context, a block is a collection of primitives which would want to be placed in the same location (i.e. they want to move together). Currently, each block represents a pack molecule (created by the Prepacker). The nets are logical connections between blocks. The APNetlist will not contain any nets which are not needed for AP. The APNetlist is tested using a Unit Test which tests its basic functionality (features that differ from the base Netlist class). This is the first of many commits which will bring Analytical Placement into VPR.
AlexandreSinger
force-pushed
the
feature-ap-upstreaming
branch
from
24732b6 to
7f868f3
Compare
vaughnbetz
approved these changes
Sep 23, 2024
Feedback from Vaughn, who thinks that APBlockType was a bit ambiguous and may cause problems later. He recommended calling it mobility instead.
|
@vaughnbetz This has passed all of the regular CI tests. The NightlyTests seem to be failing again; however, I think this PR can still be merged since it does not touch any of the code in NightlyTests. Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The APNetlist class holds the blocks and nets used during the AP flow. In the AP context, a block is a collection of primitives which would want to be placed in the same location (i.e. they want to move together). Currently, each block represents a pack molecule (created by the Prepacker). The nets are logical connections between blocks. The APNetlist will not contain any nets which are not needed for AP.
The APNetlist is tested using a Unit Test which tests its basic functionality (features that differ from the base Netlist class).
This is the first of many commits which will bring Analytical Placement into VPR.