Skip to content

Fix compilation error with VTR_ASSERT_LEVEL=4 #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix compilation error with VTR_ASSERT_LEVEL=4 #2707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16a9cc0
fix the compilation error with VTR_ASSERT_LEVEL=4
soheilshahrouz Aug 28, 2024
617b097
test vtr_reg_basic with VTR_ASSERT_LEVEL=4
soheilshahrouz Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,11 @@ jobs:
params: '-DCMAKE_COMPILE_WARNING_AS_ERROR=on -DVTR_ASSERT_LEVEL=3 -DWITH_BLIFEXPLORER=on',
suite: 'vtr_reg_basic'
},
{
name: 'Basic with highest assertion level',
params: '-DCMAKE_COMPILE_WARNING_AS_ERROR=on -DVTR_ASSERT_LEVEL=4 -DWITH_BLIFEXPLORER=on',
suite: 'vtr_reg_basic'
},
{
name: 'Basic_odin',
params: '-DCMAKE_COMPILE_WARNING_AS_ERROR=on -DVTR_ASSERT_LEVEL=3 -DWITH_BLIFEXPLORER=on -DWITH_PARMYS=OFF -DWITH_ODIN=on',
Expand Down
2 changes: 1 addition & 1 deletion vpr/src/place/place_timing_update.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ void update_td_costs(const PlaceDelayModel* delay_model,

#ifdef VTR_ASSERT_DEBUG_ENABLED
double check_timing_cost = 0.;
comp_td_costs(delay_model, place_crit, &check_timing_cost);
comp_td_costs(delay_model, place_crit, placer_state, &check_timing_cost);
VTR_ASSERT_DEBUG_MSG(check_timing_cost == *timing_cost,
"Total timing cost calculated incrementally in update_td_costs() is "
"not consistent with value calculated from scratch in comp_td_costs()");
Expand Down
Loading