cluster_placement.h is missing #include vpr_types.h #2617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cluster_placement.h needs vpr_types.h for definitions of t_pack_molecule and t_cluster_placement_stats.
added #include "vpr_types.h" to cluster_placement.h
Related Issue
Motivation and Context
VPR fails to compile when cluster_placement.h is included in a .cpp file that does not include vpr_types.h earlier in the file.
How Has This Been Tested?
VPR still compiles and there is no change in QoR (based on quick neuron test referenced in another PR).
Types of changes
Checklist: