Skip to content

Minor router lookahed cleanup #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 29, 2024
Merged

Minor router lookahed cleanup #2563

merged 4 commits into from
May 29, 2024

Conversation

soheilshahrouz
Copy link
Contributor

I cleaned up parts of router lookahed code when I was reading it.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool libarchfpga Library for handling FPGA Architecture descriptions lang-cpp C/C++ code labels May 27, 2024
vaughnbetz
vaughnbetz reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to consider, none critical.

@vaughnbetz
Copy link
Contributor

I hear you have Titan runtime results -- good to attach just for documentation & safety.

@soheilshahrouz
Copy link
Contributor Author

QoR for Titan23

@vaughnbetz
Copy link
Contributor

Thanks. QoR looks good; merging.

@vaughnbetz vaughnbetz merged commit 9343ee9 into master May 29, 2024
102 checks passed
@vaughnbetz vaughnbetz deleted the temp_cleanup_ branch May 29, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz vaughnbetz left review comments

Assignees
No one assigned
Labels
lang-cpp C/C++ code libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soheilshahrouz @vaughnbetz