Skip to content

Fix the S10 arch file comments for routing segments and switches #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2024

Conversation

kimiatkh
Copy link
Contributor

Description

This PR addresses the outdated comments for the routing architecture model of the S10 architecture file. The comments were based on an old version of VPR where different x and y wire segments could not be modeled. The comments have been updated to reflect the new routing model that captures horizontal and vertical routing wires separately.

Types of changes

  • [ x] Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@kimiatkh kimiatkh requested a review from vaughnbetz May 26, 2024 16:22
@vaughnbetz
Copy link
Contributor

Thanks @kimiatkh !

@vaughnbetz vaughnbetz merged commit 6cbf119 into master May 27, 2024
102 checks passed
@vaughnbetz vaughnbetz deleted the s10_fix_comments branch May 27, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants