[CI] Made the Regression Tests Error on Warning #2555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infra
To prevent warnings from showing up in the build in the future, made the CI error on any warnings during the regression tests. It looks like VPR originally had the ability to error on warning; however, it was specific to only VPR. This CMAKE method will now work for all executables compiled during the tests. May want to consider removing it in the future.
AlexandreSinger
force-pushed
the
feature-ci-error-on-warning
branch
from
7965fea to
37c6973
Compare
|
To demonstrate the importance of these changes, a commit was merged yesterday which introduced more warnings: The commit removed the use of a variable when debug logging is enabled,. Hence why two of the tests failed. These warnings build up fast I guess. |
|
Ah, a warning snuck back in already! |
github-actions
bot
added
VPR
|
@vaughnbetz It looks like we were correct. Even though the Bison deprecation warnings are still there, this method of failing on warning does not fail the CI in this case. This is actually a good thing. As we discussed this may mean that we can keep the deprecations without suppressing them. |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent warnings from showing up in the build in the future, made the
CI error on any warnings during the regression tests.
It looks like VPR originally had the ability to error on warning;
however, it was specific to only VPR. This CMAKE method will now work
for all executables compiled during the tests.
With this merged, this should completely resolve issue #2518