Skip to content

Architecture Seg Fault Issue #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2024
Merged

Architecture Seg Fault Issue #2552

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa76412
bug fixed, used to check number of layouts instead of number of layers
saaramahmoudi May 14, 2024
6e28a9a
changed the hardcoded 0 and 1 indicies to constexpr
saaramahmoudi May 14, 2024
6c4f17e
removed compiler issue
saaramahmoudi May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions libs/libarchfpga/src/echo_arch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,13 @@ void PrintArchInfo(FILE* Echo, const t_arch* arch) {
}

fprintf(Echo, "\tInput Connect Block Switch Name Within a Same Die: %s\n", arch->ipin_cblock_switch_name[0].c_str());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth commenting the [0] and [1] indices: [0] is the ipin_cblock_switch_name for within die and [1] is between dice? This might be more clear with constexpr that gives names to 0 and 1 for the lookups.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaughnbetz fixed it


//if there is more than one layer available, print the connection block switch name that is used for connection between two dice
if (arch->grid_layouts.size() > 1) {
fprintf(Echo, "\tInput Connect Block Switch Name Between Two Dice: %s\n", arch->ipin_cblock_switch_name[1].c_str());
for(const auto& layout : arch->grid_layouts){
int num_layers = (int)layout.layers.size();
if(num_layers > 1){
fprintf(Echo, "\tInput Connect Block Switch Name Between Two Dice: %s\n", arch->ipin_cblock_switch_name[1].c_str());
}
}

fprintf(Echo, "*************************************************\n\n");
Expand Down Expand Up @@ -287,9 +291,12 @@ void PrintArchInfo(FILE* Echo, const t_arch* arch) {
fprintf(Echo, "\t\t\t\ttype unidir mux_name for within die connections: %s\n",
arch->Switches[seg.arch_wire_switch].name.c_str());
//if there is more than one layer available, print the segment switch name that is used for connection between two dice
if (arch->grid_layouts.size() > 1) {
fprintf(Echo, "\t\t\t\ttype unidir mux_name for between two dice connections: %s\n",
for(const auto& layout : arch->grid_layouts){
int num_layers = (int)layout.layers.size();
if(num_layers > 1){
fprintf(Echo, "\t\t\t\ttype unidir mux_name for between two dice connections: %s\n",
arch->Switches[seg.arch_opin_between_dice_switch].name.c_str());
}
}
} else { //Should be bidir
fprintf(Echo, "\t\t\t\ttype bidir wire_switch %s arch_opin_switch %s\n",
Expand Down
Loading