Skip to content

Specify available moves explicitly #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2024
Merged

Conversation

soheilshahrouz
Copy link
Contributor

Currently, we pass the number of available moves to the KArmedBanditAgent's constructor to specify which moves are available. This interface assumes that move types have a specific order. This PR changes the interface so that available moves can be specified explicitly.

The main motivation for this PR is to add NoC-specific move types that are disabled for conventional architectures.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool libarchfpga Library for handling FPGA Architecture descriptions lang-cpp C/C++ code libvtrutil labels Apr 20, 2024
@soheilshahrouz soheilshahrouz changed the title Specify moves explicitly Specify available moves explicitly Apr 22, 2024
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested clean up (use a vector of names / properties) for the move types.

@soheilshahrouz
Copy link
Contributor Author

@vaughnbetz

I applied your comments. Here is the link to QoR for Titan that shows the new interface for specifying availale move types does not degraged the runtime.

@vaughnbetz vaughnbetz merged commit 9cc02c3 into master May 13, 2024
100 checks passed
@vaughnbetz vaughnbetz deleted the specify_moves_explicitly branch May 13, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code libarchfpga Library for handling FPGA Architecture descriptions libvtrutil VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants