Skip to content

Fix PR labeler #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Fix PR labeler #2486

merged 1 commit into from
Feb 7, 2024

Conversation

soheilshahrouz
Copy link
Contributor

Description

If someone submits a PR from a forked repository, the labeler would not have write permission to the PR to add labels. As a result, PRs from forked repos are not labeled. This PR fixes this problem.

Related Issue

There is no open issue for this PR.

How Has This Been Tested?

It is not tested because I could not find a way to test this. The labeler reads labeler.yml on the master branch. So, we cannot test if this PR solves the issue until it is merged into master. However, Github documentation is very clear on this problem. In worst case, if anything goes wrong, I can make another PR and revert this change.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@vaughnbetz vaughnbetz merged commit 3e15bf3 into master Feb 7, 2024
@vaughnbetz vaughnbetz deleted the fix_pr_labeler branch February 7, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants