Skip to content

Noc QoR measurement #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Feb 2, 2024
Merged

Noc QoR measurement #2479

merged 18 commits into from
Feb 2, 2024

Conversation

soheilshahrouz
Copy link
Contributor

@soheilshahrouz soheilshahrouz commented Jan 21, 2024

Description

This PR adds scripts, VTR tasks, and documentaion to facilitate QoR measurement for NoC benchmarks.

Related Issue

Issue 2436

Motivation and Context

Prior to this PR, QoR measurements for NoC benchmarks were neither documented nor automated. This PR adds a script to download blif files for MLP benchmarks, adds VTR tasks to run NoC benchmarks and measure QoR metrics, and documents how these tasks and script can be used to automate QoR measurement for NoC benchmarks.

How Has This Been Tested?

NoC QoR measurement tasks were run on wintermure.
The Pyhton script for downloading and integrating MLP benchmarks was tested on wintermute and a machine outside the EECG network.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added docs Documentation build Build system lang-python Python code lang-make CMake/Make code lang-netlist labels Jan 21, 2024
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just asking for commenting in some places and one variable name change.

@soheilshahrouz
Copy link
Contributor Author

@vaughnbetz
I applied your comments. Can you please take a quick look and see if it is ready to be merged?

@vaughnbetz vaughnbetz merged commit 451fb4d into master Feb 2, 2024
@vaughnbetz vaughnbetz deleted the noc_qor_doc_issue branch February 2, 2024 03:41
@soheilshahrouz soheilshahrouz restored the noc_qor_doc_issue branch February 12, 2024 20:12
@soheilshahrouz soheilshahrouz deleted the noc_qor_doc_issue branch April 10, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system docs Documentation lang-make CMake/Make code lang-netlist lang-python Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants