Skip to content

Fix Seg Fault error when reading in an RR Graph with different x-y segment types #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

kimiatkh
Copy link
Contributor

Description

The pull request is to fix the segmentation fault that occurred when reading in the rr graph that had different segment types in the X and Y directions. The error was caused by some parts of the code that set the node cost index, which still relied on the assumption that the X and Y axes have the same segment types. The issue has been fixed by updating the relevant code.

How Has This Been Tested?

The changes have been tested using the Stratix 10 architecture. Before the fix, the rr graph could not be read in properly, resulting in the segmentation fault. After applying the fix, the issue has been resolved, and the rr graph is now correctly processed without any errors.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@kimiatkh kimiatkh requested a review from vaughnbetz July 24, 2023 14:31
@vaughnbetz
Copy link
Contributor

Looks good, thanks.

@vaughnbetz vaughnbetz merged commit 9479f9d into master Jul 24, 2023
@vaughnbetz vaughnbetz deleted the fix_read_rr_graph_diff_x_y_chann branch July 24, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants