-
Notifications
You must be signed in to change notification settings - Fork 415
Read flat router .route file #2343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vaughnbetz @amin1377 please review the changes. |
The code looks good.
|
@vaughnbetz It wouldn't be seg-fault, it will be out with an assertion which tell the user that rr-graph node in the .route file doesn't exist. |
We should replace the assert with an error message that gives them an idea of what went wrong (rr-node does not exist. Running without flat routing; if this file was created with flat routing, re-run vpr with the --flat_routing option @amin1377 : It doesn't seem the flat routing option is documented in the vpr command line options. Can you add it? |
There is a brief description available if you run |
Thanks. Yes, we should put it in the online documentation too. |
@vaughnbetz Three places can give us error if we read .route file that is generated with flat router, I added message for all three that maybe the user should try --flat_routing true option. |
@vaughnbetz can you please merge this? |
Description
Once we used flat router to route the design, newly generated .route file couldn't be read by VPR anymore. We couldn't load any .route file generated by flat router. This PR address this issue and add support for reading any .route file regardless of how it is generated (normal or flat routing).
NOTE: you still need to pass flat_routing true as command-line option if you generated .route file using flat router.
Types of changes
Checklist: