Skip to content

Vpr noc output #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 13, 2023
Merged

Vpr noc output #2333

merged 5 commits into from
Jun 13, 2023

Conversation

Meet-Patel2580
Copy link
Contributor

@Meet-Patel2580 Meet-Patel2580 commented Jun 6, 2023 •
edited
Loading

Updating NoC usage output message format

Description

Updated the NoC usage output messages to organize the data into a table for better visual appeal and intuitiveness

Related Issue

Motivation and Context

Makes it easier for users to view the information when it is organized

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@Meet-Patel2580
Modified print_placement_move_types_stats() function
02a4371 
Modified print_placement_move_types_stats() function to create a table to show the statistics in a more organized and intuitive manner.
@Meet-Patel2580
Update place.cpp
861f5e9 
Removed repetitive entries in the "block type" column to improve visual appeal.
@vaughnbetz
Copy link
Contributor

Please add an example output so we can look at.

@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label Jun 6, 2023
@saaramahmoudi saaramahmoudi self-requested a review June 6, 2023 22:03
@Meet-Patel2580
Copy link
Contributor Author

Here is an example of the updated output (table) compared to the original output.

Screenshot 2023-06-07 at 3 12 11 PM

Screenshot 2023-06-07 at 3 13 21 PM

@Meet-Patel2580
updated place.cpp (make format)
a496cf1 
Ran make format to pass all CI tests.
saaramahmoudi
saaramahmoudi approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@saaramahmoudi saaramahmoudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks fine. Thanks!

@vaughnbetz
Copy link
Contributor

vaughnbetz commented Jun 7, 2023 •
edited
Loading

Looks good. A few suggested tweaks:
Title: I'd change to "Placement perturbation distribution by block and move type"
Percentage(%) --> % of Total
Acceptance -> Accepted
Rejection -> Rejected

Round off the "Percentage(%)" column values to 2 digits after the decimal.

Meet-Patel2580 and others added 2 commits June 7, 2023 18:21
@Meet-Patel2580
Modified place.cpp
a738c49 
Made small adjustments to the names of the headers, and fixed spacing.
@vaughnbetz
Merge branch 'master' into vpr_noc_output
f46142f
@Meet-Patel2580
Copy link
Contributor Author

Updated output table with suggested changes:
Screenshot 2023-06-07 at 6 27 10 PM

@Meet-Patel2580
Copy link
Contributor Author

Ready to be merged. @vaughnbetz

@vaughnbetz vaughnbetz merged commit 6e0fa63 into master Jun 13, 2023
@vaughnbetz vaughnbetz deleted the vpr_noc_output branch June 13, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saaramahmoudi saaramahmoudi saaramahmoudi approved these changes

Assignees
No one assigned
Labels
VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Meet-Patel2580 @vaughnbetz @saaramahmoudi