Updated graphics.rst (Documentation) #2326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the documentation for VPR graphics by adding new images of the UI as well as fixing grammatical errors and descriptions of the locations of various buttons.
Created an Images folder to hold images of the documentation.
vaughnbetz
requested changes
May 30, 2023
|
Looks good; one suggested change. Then ping me to merge. Right after merging, check the web page to make sure all the images show up. |
|
Another item to investigate (but should be another issue): can we show only the highlighted nets (fanin and fanout of selected block)? I think we should rename "None" to "Highlighted Only" and then made placement draw the highlighted cluster nets / highlighted primitive nets (depending on what was clicked on). |
|
Should also change the code to have "Set Net Transparency" --> Net Transparency (0 - 255) |
Updated the toggle options to Cluster Nets and Primitive Nets from Nets and Logical Connections respectively.
Updated intra_logic_block.cpp to match the new name of the global variable "Draw_logical_connections" to "draw_primitive_nets".
Updated VPR documentation due to a change in the "Toggle Nets" dropdown list to better describe the options. Added updated image as well.
Changed "Set Net Transparency" to "Net Transparency (0 - 255)"
|
All suggested changes made. @vaughnbetz , You may now merge this PR, and I will check right after to make sure the images on the documentation are showing up properly. |
|
Thanks Meet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the documentation for VPR graphics by adding new images of the UI as well as fixing grammatical errors and descriptions of the locations of various buttons.
Description
Related Issue
Motivation and Context
The existing documentation displayed an older version of the user interface and was required to be updated with newer images as well as an updated description of how to use certain features.
How Has This Been Tested?
Types of changes
Checklist: