Skip to content

NoC Placement Code Improvement #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
May 19, 2023
Merged

NoC Placement Code Improvement #2315

merged 32 commits into from
May 19, 2023

Conversation

saaramahmoudi
Copy link
Contributor

@saaramahmoudi saaramahmoudi commented May 15, 2023 •
edited
Loading

Description

This pull request is made based on issue 2262, and applied some code improvements for NoC placer functions and data structures.
@vaughnbetz

Related Issue

issue 2262

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code Improvement

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

saaramahmoudi added 23 commits May 8, 2023 16:01
@saaramahmoudi
removed a single comparison function to a if condition (item 1 in iss…
3620dfd 
…ue 2262)
@saaramahmoudi
Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…
4f11614 
…rilog-to-routing into noc_refactor
@saaramahmoudi
fixed some comments typos
83a57b3
@saaramahmoudi
simplified update_traffic_flow_link_usage (item 5 in issue 2262)
e56b21e
@saaramahmoudi
Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…
c3d2c21 
…rilog-to-routing into noc_refactor
@saaramahmoudi
make format executed
0affc74
@saaramahmoudi
found a comment typo, update some comments
9004a2a
@saaramahmoudi
changed noc internal datastructure to reduce propose_router_swap time…
d1a9bc0 
… complexity (item 2 in issue 2262)
@saaramahmoudi
commented the modified data structure, fixed some comments' typos
9d377c9
@saaramahmoudi
make format
b217272
@saaramahmoudi
removed extra casting
9a05c69
@saaramahmoudi
created a struct for each traffic flow agg_bandwidth and latency (ite…
c1a8404 
…m 3 in issue 2262)
@saaramahmoudi
C++ formatting
efd718e
@saaramahmoudi
changed function arguments from pointer ro ref (item 6 in issue 2262)
a11dc3b
@saaramahmoudi
fixed test_noc_traffic_flow.cpp to work with new function params
8937c91
@saaramahmoudi
resolved conflicts with master branch
82b3073
@saaramahmoudi
removed some extra casting between loop variable and NoCTrafficFlowId…
95aa796 
… by using range-based loop for affected_traffic_flow data structure (item 4 in issue 2262)
@saaramahmoudi
removed extra function argument from commit_noc_costs
3c70337
@saaramahmoudi
removed extra conversion
a50c9a4
@saaramahmoudi
fixed all unnecessary casting in NoC-related code (item 4 in issue 2262)
a9734ef
@saaramahmoudi
changed NoC data structures and function call to avoid passing unnece…
a46d081 
…ssary function arguments
@saaramahmoudi
fixed compiler issues with noc unit tests
b38dd66
@saaramahmoudi
make format
ed122fd
@saaramahmoudi saaramahmoudi requested a review from vaughnbetz May 15, 2023 18:48
@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label May 15, 2023
vaughnbetz
vaughnbetz requested changes May 18, 2023
View reviewed changes
vaughnbetz
vaughnbetz reviewed May 18, 2023
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good; just suggest changing a reference to a const reference in one spot (always do this for references you only read from, and always use const & instead of pass by value for big read-only data structures).

vpr/src/noc/noc_traffic_flows.h Outdated
* ClusterBlockId extracted from netlist.
*
*/
void set_router_cluster_in_netlist(std::vector<ClusterBlockId>& routers_cluster_id_in_netlist);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use a const & instead of an &

@saaramahmoudi
Copy link
Contributor Author

@vaughnbetz Ready to merge.

@vaughnbetz vaughnbetz merged commit 924fd89 into master May 19, 2023
@vaughnbetz vaughnbetz deleted the noc_refactor branch May 19, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz vaughnbetz requested changes

Assignees
No one assigned
Labels
VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saaramahmoudi @vaughnbetz