This is a fix to avoid division by zero in initial_placement. #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching that, I think we should merge this. @vaughnbetz |
saaramahmoudi
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We successfully adapted VPR to a different build system and compiler, but the execution failed when the code attempted to do a division by zero. Illegal instruction.
Motivation and Context
The prior code worked, but it relied on a floating point division by zero resulting in an "inf" and then being converted to an int. This was sloppy, and relies on particular treatment of a SIGFPE. I think it is much cleaner, and more portable to avoid division if the divisor is zero.
How Has This Been Tested?
Built in our system and tested.