Initialized enums that might not be assigned depending on NO_GRAPHICS macro #2187
Conversation
… macro. Signed-off-by: Henner Zeller <[email protected]>
hzeller
force-pushed
the
20221103-initialize-enums
branch
from
81637b6 to
77352cf
Compare
| @@ -1462,7 +1462,7 @@ static e_move_result try_swap(const t_annealing_state* state, | |||
| rlim = state->rlim; | |||
| } | |||
|
|
|||
| e_create_move create_move_outcome; | |||
| e_create_move create_move_outcome = e_create_move::ABORT; | |||
|
|
|||
There was a problem hiding this comment.
I think we should move the #ifndef NO_GRAPHICS here and the #endif after "} else" and before the "if" in line 1472 so that the manual_move_enabled will only be checked if the graphics are enabled (NO_GRAPHICS isn't defined). Then, create_move_outcome will be initialized in all the cases.
There was a problem hiding this comment.
@hzeller : any thoughts on Mohamed's comment? I'm OK with merging as is, but if you and @MohamedElgammal have a better fix please make the change now so we fix this one way or the other.
There was a problem hiding this comment.
I like the suggestion, but I am busy with other things currently, so if we merge it now, I leave it to @MohamedElgammal to do another PR to improve the situation.
|
OK, made an issue to track that. |
small cleanup.