Fix rr_graph direct link #2146
Merged
Fix rr_graph direct link #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaughnbetz
reviewed
Aug 28, 2022
| @@ -2962,12 +2962,20 @@ static int get_opin_direct_connections(RRGraphBuilder& rr_graph_builder, | |||
| } | |||
| } | |||
|
|
|||
| int target_sub_tile = z + directs[i].sub_tile_offset; | |||
| if (relative_ipin >= target_type->sub_tiles[target_sub_tile].num_phy_pins) continue; | |||
| int target_cap = z + directs[i].sub_tile_offset; | |||
There was a problem hiding this comment.
Can you comment what the logic is here?
|
|
||
| //If this block has capacity > 1 then the pins of z position > 0 are offset | ||
| //by the number of pins per capacity instance | ||
| int ipin = get_physical_pin_from_capacity_location(target_type, relative_ipin, target_sub_tile); | ||
| int ipin = get_physical_pin_from_capacity_location(target_type, relative_ipin, target_cap); |
There was a problem hiding this comment.
Is the comment above still correct? I'm not seeing the logic of how the pins wrap around (pins of z position > 0 offset by number of pins per capacity instance).
There was a problem hiding this comment.
"relative_pin" shows the pin number in its capacity. So, to get the number of the pin at tile-level, "relative_ipin" should be added by the number of pins on prior sub_tiles and capacities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created to fix issue #2145
@vaughnbetz