Skip to content

Fixed Bug where VPR UI was not changing when switching mode #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

SebastianLievano
Copy link
Contributor

There was a bug where as you proceeded through placement and routing of a circuit, the UI options/buttons available would not update to reflect the new state of vpr. This was caused by two things:

  1. In the new initial setup functions, a guard if statement was placed that would return if a new window was not being created, which worked in the old nested format, but now that we are not nesting initial setup functions, we need to instead check if it is a new window, and only run the default_setup function if it is new.
  2. When hiding menu options, we were using gtk_widget_hide, but were not using gtk_widget_show when showing menu options.

These bugs have been fixed in this PR.

@SebastianLievano
Copy link
Contributor Author

@kimiatkh @vaughnbetz Here is the fix for the bug Kimia brought up on Thursday. I've run through a few circuits and it seems to work. Please let me know if you find any other issues. Sorry about that.

@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label Aug 14, 2022
@vaughnbetz vaughnbetz merged commit 4247689 into master Aug 15, 2022
@vaughnbetz vaughnbetz deleted the Seb_UIInitSetupFix branch August 15, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants