Skip to content

Build on M1 #2119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Build on M1 #2119

merged 2 commits into from
Sep 6, 2022

Conversation

meme
Copy link
Contributor

@meme meme commented Aug 7, 2022

This allows vpr to be built on M1 MacBooks

Description

For this to work, you need tbb@2020 from Homebrew.

I was able to build the software using this CMake command:

TBBROOT=$(brew --prefix)/opt/tbb@2020/ cmake -DCMAKE_BUILD_TYPE=Release -DVPR_USE_EZGL=OFF -G Ninja -S . -B build

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

This allows vpr to be built on M1 MacBooks. For this to work, you need
tbb@2020 from Homebrew.

I was able to build the software using this CMake command:

    TBBROOT=$(brew --prefix)/opt/tbb@2020/ cmake -DCMAKE_BUILD_TYPE=Release -DVPR_USE_EZGL=OFF -G Ninja -S . -B build
@github-actions github-actions bot added ABC ABC Logic Optimization & Technology Mapping Tool external_libs libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool labels Aug 7, 2022
@vaughnbetz
Copy link
Contributor

Thanks for the contribution.
The changes look OK to me, and I've started CI.
@duck2 : there are some tbb build changes here to be compatible with apple. I know you're also planning some changes to update our tbb version; could you take a look at these build changes and see if they interact with your update or if you have any thoughts.

@vaughnbetz
Copy link
Contributor

Not sure why vtr_reg_nightly_test1 was cancelled; appeared everything in it passed already anyway.

@meme
Copy link
Contributor Author

meme commented Sep 6, 2022

Not sure why vtr_reg_nightly_test1 was cancelled; appeared everything in it passed already anyway.

It looks like it was cancelled because it hit the maximum timeout of 360 minutes. Not sure if that's related to my changes or not?

@vaughnbetz vaughnbetz requested a review from duck2 September 6, 2022 16:24
@duck2
Copy link
Contributor

duck2 commented Sep 6, 2022

The current FindTBB.cmake doesn't work with newer TBB versions anyway, so it should be OK to hack on it. The rest of the changes look good to me as well

@vaughnbetz
Copy link
Contributor

Thanks. Can't think of a reason why these changes would make us hit the 360 minute timeout (esp. after everything was done) so I'm assuming that was some transient infrastructure or load issue. Merging.

@vaughnbetz vaughnbetz merged commit 89546b7 into verilog-to-routing:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ABC ABC Logic Optimization & Technology Mapping Tool external_libs libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants