Skip to content

Dense initial placement #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Dense initial placement #2113

merged 3 commits into from
Aug 11, 2022

Conversation

saaramahmoudi
Copy link
Contributor

Initial placement used to fail in case of high utilization or long chains. New approach called dense_placement has been added to initial placement, make it possible to redo initial placement if random placement could not find a legal solution for high utilization designs.
Relate issue : [https://github.com//issues/2036#issuecomment-1184739027](Initial Placement issue)

List of Design that passing now:

  • Brainwave
  • tpu_like.small.os
  • tpu_like.small.ws
  • tpu_like.medium.os
  • tpu_like.medium.ws
  • dla_like.large

@MohamedElgammal @vaughnbetz

@saaramahmoudi saaramahmoudi added the VPR VPR FPGA Placement & Routing Tool label Aug 3, 2022
@vaughnbetz
Copy link
Contributor

Looks 3 symbiflow circuits are failing with "No routing path exists" for a special connection. Maybe some special IO placement code, or respecting locked down blocks, got changed accidentally?

@vaughnbetz
Copy link
Contributor

Good to do a QoR run to be safe (vtr and titan) and attach results.

Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the helper functions! Some comments to address.

@saaramahmoudi
Copy link
Contributor Author

Here is the comparison between new version and baseline results for three benchmarks.
titan_other
titan_quick_qor
vtr_reg_qor_chain_large

@vaughnbetz
Copy link
Contributor

Looks good. The QoR looks fine; there are some ups and downs in cpu time but that appears to be due to machine load as sometimes the new code is slower and sometimes it is faster, and there are changes in various parts of the flow (pack, place, route, even abc). Will merge once CI passes.

@vaughnbetz vaughnbetz merged commit 8e4d8ea into master Aug 11, 2022
@vaughnbetz vaughnbetz deleted the dense_initial_placement branch August 11, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants