Skip to content

Issue #2078 #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 27, 2022
Merged

Issue #2078 #2092

merged 3 commits into from
Jul 27, 2022

Conversation

amin1377
Copy link
Contributor

This PR is created to address the issue #2078
@vaughnbetz

@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label Jul 12, 2022
vaughnbetz
vaughnbetz requested changes Jul 16, 2022
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; needs a make format and I suggest a couple of commenting updates.

@amin1377
Copy link
Contributor Author

Looks good; needs a make format and I suggest a couple of commenting updates.

Done

@vaughnbetz
Copy link
Contributor

Still has a format failure -- I don't think you ran make format and commited and pushed?
Also has a read the docs failure, but no documentation was changed. Infrastructure issue that hopefully goes away if you re-run? If that one persists please file an issue on it.

@amin1377
Copy link
Contributor Author

Still has a format failure -- I don't think you ran make format and commited and pushed? Also has a read the docs failure, but no documentation was changed. Infrastructure issue that hopefully goes away if you re-run? If that one persists please file an issue on it.

Whoops...sorry. I didn't realize that I haven't run the make format. I ran it, and pushed the changes. Should the CI tests fail, I'll file an issue.

@vaughnbetz
Copy link
Contributor

Some infrastructure issues (one cmake, one read the docs). Can you rerun to see if transient (hopefully the cmake one is at least) and file issues on anything that isn't transient?

@vaughnbetz
Copy link
Contributor

Only read the docs failures, which are fixed elsewhere (infrastructure).

@vaughnbetz vaughnbetz merged commit 09d1f20 into master Jul 27, 2022
@vaughnbetz vaughnbetz deleted the double_free_route_tree branch July 27, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz vaughnbetz requested changes

Assignees
No one assigned
Labels
VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amin1377 @vaughnbetz