-
Notifications
You must be signed in to change notification settings - Fork 415
Graphics Update/New UI for VPR #2085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changed ui.h/cpp ->ui_setup
Failures so far are due to all servers busy; Sebastian tells me they passed previously. Please re-run the failed tests, but if it's holding you up I can merge in advance of those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A complete revamp of VPR's UI.
OLD UI:

NEW UI:CODE CHANGES:
a) Stop calling each other
b) Call either the setup or hide functions for different menu options depending on which ones they show
a) Function with app->get_object() which works on any object in the application
b) have _cbk in their name to make their purpose clear and prevent accidental calling in any other context
c) Be better documented (documentation was pretty good before actually, just added doxygen format)
Motivation and Context
Old UI was essentially unusable on smaller screens. Due to the manner in which buttons were created/initialized, they simply appeared in an unscrollable stack on the side. To increase usability, I sorted the menus into different dropdown options. This resembles industry standard.
How Has This Been Tested?
As each new button was created and added, its behavior was tested and compared to the same buttons performance on the master branch. To test different setup options, the cmd line was used to run vpr graphics in different stages.
Types of changes
Checklist: