Skip to content

Graphics Command Documentation Updated #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2022
Merged

Graphics Command Documentation Updated #2055

merged 4 commits into from
Jun 9, 2022

Conversation

jmah76
Copy link
Contributor

@jmah76 jmah76 commented Jun 8, 2022

Description

Documentation for running graphics commands was made more clear.

Related Issue

Running any graphics command examples from the documentation, such as sample command $VTR_ROOT/vpr/vpr $VTR_ROOT/vtr_flow/arch/timing/EArch.xml $VTR_ROOT/vtr_flow/benchmarks/blif/tseng.blif --route_chan_width 100 --analysis --save_graphics on --graphics_commands save_graphics place.png, did not work. The documentation neglected to mention that graphics commands must be surrounded by quotation marks, as argparse considers space filled strings as multiple arguments even if the user intended it to be just one.

A fix to Issue #2001.

How Has This Been Tested?

Ran
$VTR_ROOT/vpr/vpr $VTR_ROOT/vtr_flow/arch/timing/EArch.xml $VTR_ROOT/vtr_flow/benchmarks/blif/tseng.blif --route_chan_width 100 --analysis --save_graphics on --graphics_commands save_graphics place.png; set_nets 1; save_graphics nets1.png; set_nets 2; save_graphics nets2.png; set_nets 0;
and
$VTR_ROOT/vpr/vpr $VTR_ROOT/vtr_flow/arch/timing/EArch.xml $VTR_ROOT/vtr_flow/benchmarks/blif/tseng.blif --route_chan_width 100 --analysis --save_graphics on --graphics_commands "save_graphics place.png; set_nets 1; save_graphics nets1.png; set_nets 2; save_graphics nets2.png; set_nets 0;".

The former returns

Unexpected command-line argument 'place.png' 

usage: vpr architecture circuit [--pack] [--place] [--route] [--analysis]
       [--disp {on, off}] [--save_graphics {on, off}]
       [--graphics_commands GRAPHICS_COMMANDS] [-h] [--version]
       [--device DEVICE_NAME] [-j NUM_WORKERS] [--timing_analysis {on, off}]
       [--disable_errors DISABLE_ERRORS] [--suppress_warnings SUPPRESS_WARNINGS]
       [--route_chan_width CHANNEL_WIDTH] [OTHER_OPTIONS ...]
set_nets: command not found
save_graphics: command not found
set_nets: command not found
save_graphics: command not found
set_nets: command not found

while the latter works.

Checklist:

  • My change requires a change to the documentation
  • [X ] I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label Jun 8, 2022
@vaughnbetz
Copy link
Contributor

Looks good; thanks.

@vaughnbetz vaughnbetz merged commit d2095e5 into master Jun 9, 2022
@vaughnbetz vaughnbetz deleted the graphics_cmd_fix branch June 9, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants