Skip to content

Building a re-clustering API (cont.) #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MohamedElgammal
Copy link
Contributor

@MohamedElgammal MohamedElgammal commented Jun 7, 2022

Description

In this PR, the second function of re-cluster is implemented. This API should allow the users to change clustering decisions after the clustering is done. These changes can be done during packing or placement.

The second function in the API implemented in this PR can move an atom out of a cluster and add it to an existing cluster. More Functions for this API are to be implemented in upcoming PRs.

The function was tested on VTR benchmarks and unit tests will be added when the API is completed in the upcoming PRs.

Related PRs

This PR is a follow-up pull request on the PR #2034

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label Jun 7, 2022
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
Some suggested commenting and helper function creation / refactoring updates.

/*******************************************************************
* Place Related
*******************************************************************/
enum e_pad_loc_type pad_loc_type;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not quite sure why this is needed in the atom context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants