Removed 3 unused if conditions from ODIN's partial_map.cpp. #2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alirezazd
changed the title
|
@alirezazd - LGTM, Thanks! Can you please update your branch with the master branch and squash all commits into one commit? Then it will be ready to merge into the master branch. |
alirezazd
force-pushed
the
removed_unused_if_statements
branch
from
a752a05 to
720c4e9
Compare
|
@sdamghan Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found 3 unused if statements in ODIN's partial_map.cpp which they were never executed and removed them from the source.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: