Skip to content

Document VPR placement constraints #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

sfkhalid
Copy link
Contributor

Description

Added a documentation page to describe how a user can run VPR with placement constraints.

Related Issue

Related to the features add for issue #932.

@sfkhalid sfkhalid changed the title Added a new file for documenting VPR placement constraints Document VPR placement constraints Apr 14, 2022
@vaughnbetz
Copy link
Contributor

@sfkhalid : please address the comments before we meet tomorrow so we can get this one merged.

@vaughnbetz
Copy link
Contributor

@kgugala @mithro : seems the google cloud is failing on most or all of the tests that are going to it on this PR. I think the tests that passed are those run on github's resources. Error is the usual resource one:
ERROR: (gcloud.beta.compute.instances.create) Could not fetch resource:
14:44:51 | - The zone 'projects/***/zones/us-west1-a' does not have enough resources available to fulfill the request. '(resource type:compute)'.
Can we move to a different cloud region or make some other setting change to get this going? At this point the google cloud seems significantly less reliable than kokoro was, unfortuntely.

@vaughnbetz
Copy link
Contributor

Changes look good; this is ready to merge when CI goes green (or I could merge without CI as Sarah tells me the documentation builds).

@vaughnbetz
Copy link
Contributor

Read the docs test passed and all the failures look like unrelated google cloud issues; merging.

@vaughnbetz vaughnbetz merged commit a6538ac into master Jun 2, 2022
@vaughnbetz vaughnbetz deleted the add_place_constraints_documentation branch June 2, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants