Skip to content

Add missing include for <algorithm>. #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2022
Merged

Add missing include for <algorithm>. #1992

merged 1 commit into from
Mar 8, 2022

Conversation

hzeller
Copy link
Contributor

@hzeller hzeller commented Mar 7, 2022 •
edited
Loading

There is a change in llvm that soon won't automatically
surface symbols from a transitive include of <algorithm>, so we need to make sure to IWYU.

@hzeller
Add missing include for <algorithm>.
4ecdb5d 
There is a
[change in llvm](https://github.com/verilog-to-routing/vtr-verilog-to-routing.git)
that soon won't automatically surface symbols from a transitive
include of `<algorithm>`, so we need to make sure to IWYU.

Signed-off-by: Henner Zeller <[email protected]>
@hzeller hzeller force-pushed the fix-missing-algorithm-include branch from 229ab31 to 4ecdb5d Compare March 7, 2022 17:27
mithro
mithro approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merge if CI says yes.

@hzeller hzeller merged commit 220fa98 into verilog-to-routing:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
libvtrutil
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hzeller @mithro