-
Notifications
You must be signed in to change notification settings - Fork 414
ci: merge workflow 'large-tests' into 'test' #1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the only thing is that I'd probably set the cron scheduler to run more frequently, maybe once a day rather than once a week (as it is set in tests.yml
)
I changed the schedule to daily, and I rebased on top of |
If CI says yes, merge away. |
@acomodi, now rebased 😉 |
@acomodi can you please merge? |
@umarcor Sorry, I lost track of this. Can you please rebase once again on top of master (I think there were some merges in between)? then I believe we can merge this. |
@acomodi, done! |
Signed-off-by: Unai Martinez-Corral <[email protected]>
Signed-off-by: Unai Martinez-Corral <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@acomodi can you please merge? |
Description
Since the events that trigger both workflows are the same, it's not worth having them separated.
Related Issue
None
Motivation and Context
See Description above.
How Has This Been Tested?
It's CI.
Types of changes
Checklist: