Skip to content

ci: merge workflow 'large-tests' into 'test' #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Feb 23, 2022

Description

Since the events that trigger both workflows are the same, it's not worth having them separated.

Related Issue

None

Motivation and Context

See Description above.

How Has This Been Tested?

It's CI.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the infra Project Infrastructure label Feb 23, 2022
@mithro mithro requested a review from acomodi February 23, 2022 16:46
Copy link
Collaborator

@acomodi acomodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only thing is that I'd probably set the cron scheduler to run more frequently, maybe once a day rather than once a week (as it is set in tests.yml)

@umarcor
Copy link
Contributor Author

umarcor commented Feb 23, 2022

I changed the schedule to daily, and I rebased on top of master.

@mithro
Copy link
Contributor

mithro commented Feb 23, 2022

If CI says yes, merge away.

@acomodi
Copy link
Collaborator

acomodi commented Feb 24, 2022

@umarcor there is a conflict due to #1985. We should still disable the "large" tests to run on forks and move the condition to the Run-tests job

@umarcor
Copy link
Contributor Author

umarcor commented Feb 24, 2022

@acomodi, now rebased 😉

@umarcor
Copy link
Contributor Author

umarcor commented Mar 2, 2022

@acomodi can you please merge?

@acomodi
Copy link
Collaborator

acomodi commented Mar 11, 2022

@umarcor Sorry, I lost track of this. Can you please rebase once again on top of master (I think there were some merges in between)? then I believe we can merge this.

@umarcor
Copy link
Contributor Author

umarcor commented Mar 15, 2022

@acomodi, done!

Copy link
Collaborator

@acomodi acomodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umarcor
Copy link
Contributor Author

umarcor commented Mar 22, 2022

@acomodi can you please merge?

@acomodi acomodi merged commit 58f5413 into verilog-to-routing:master Mar 22, 2022
@umarcor umarcor deleted the ci/merge branch March 22, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Project Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants