-
Notifications
You must be signed in to change notification settings - Fork 415
Optimize floorplan checks during place moves #1983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sfkhalid
merged 7 commits into
master
from
optimize_floorplan_checks_during_place_moves
Feb 25, 2022
Merged
Optimize floorplan checks during place moves #1983
sfkhalid
merged 7 commits into
master
from
optimize_floorplan_checks_during_place_moves
Feb 25, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct the range limit for a move with floorplan constraint before choosing a move location. This lessens place time when running with floorplan constraints
…xtra pack iteration where attraction groups are turned on for all attraction groups
sfkhalid
commented
Feb 17, 2022
sfkhalid
commented
Feb 17, 2022
sfkhalid
commented
Feb 17, 2022
sfkhalid
commented
Feb 17, 2022
sfkhalid
commented
Feb 17, 2022
sfkhalid
commented
Feb 17, 2022
QoR comparison on this branch: |
All checks passed and QoR has been checked, merging this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During place moves, if a cluster is constrained, we do an additional step of intersecting the cluster's move range limit with its floorplan constraint before we create a move.
Related Issue
Related to adding floorplan constraints to VPR - issue #932
Motivation and Context
When running with floorplan constraints, placement time was increasing due to an increased number of aborted moves. This increase was a result of moves being created that moved the block out of its floorplan constraints. By adjusting the range limit, we reduce the number of moves that are illegal with respect to floorplanning and so the place time decreases. Although the place time still increases relative to running with no constraints, the increase is minimized.
The reduction in place time on different titan circuits that were run with floorplan constraints can be seen here:
titan_QoR_results_round2.xlsx